[CI] Disable publishing failing scans #21528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good, a bit surprising that the plugin uses a top-level property, not something like |
hamzaremmal
approved these changes
Sep 3, 2024
adpi2
added a commit
that referenced
this pull request
Sep 11, 2024
#21528 did not work: failing scans are still published. This should fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sbt command is expected to fail. Consequently its Develocity scan always appear as failed, even though the CI job succeeds. This is confusing and it makes it harder to find real failing jobs.
The solution I propose in this PR is to disable publishing the scan of the command, using
-Dscan:false.Ping @dotta